Skip to content

Adds tests for null json literals, and fixes one expected result #283

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 5 commits into from
Dec 26, 2019
Merged

Adds tests for null json literals, and fixes one expected result #283

merged 5 commits into from
Dec 26, 2019

Conversation

gkellogg
Copy link
Member

Note that this identifies an issue with the expected result for expand/0122, which was inconsistent with the spec.

For #270.

@gkellogg gkellogg requested a review from davidlehn December 24, 2019 20:26
@davidlehn
Copy link
Contributor

  • I think new js22 is same as js18?
  • These should have toRdf tests too.
  • Just noticed jsonld.js fails with an empty array @json value too. Could maybe just change js22 to that. (Or this could be filed as another issue.)

@gkellogg gkellogg merged commit c93c33b into master Dec 26, 2019
@gkellogg gkellogg deleted the issue270 branch December 26, 2019 21:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@davidlehn davidlehn Awaiting requested review from davidlehn

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@gkellogg @davidlehn